Skip to content

Conversation

@tsmith023
Copy link
Collaborator

Core PR for reference: weaviate/weaviate#6543

@tsmith023 tsmith023 requested a review from dirkkul December 5, 2024 11:48
@tsmith023 tsmith023 requested a review from a team as a code owner December 5, 2024 11:48
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@jfrancoa jfrancoa force-pushed the 1.28/support-has-permissions-endpoint branch from dcad053 to aa8eee3 Compare December 9, 2024 13:47
@jfrancoa jfrancoa force-pushed the 1.28/support-has-permissions-endpoint branch from aa8eee3 to efc57c0 Compare December 9, 2024 14:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.97%. Comparing base (79643ef) to head (efc57c0).

Files with missing lines Patch % Lines
weaviate/rbac/models.py 57.14% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev/1.28    #1457      +/-   ##
============================================
- Coverage     92.01%   91.97%   -0.04%     
============================================
  Files           174      174              
  Lines         14919    14922       +3     
============================================
- Hits          13728    13725       -3     
- Misses         1191     1197       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit 31ceb82 into dev/1.28 Dec 10, 2024
39 checks passed
@tsmith023 tsmith023 deleted the 1.28/support-has-permissions-endpoint branch December 10, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants